-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move stats to metrics #241
Conversation
@yurishkuro #226 (comment):
|
So this PR doesn't make anything worse, correct? We might need an issue for this. It is a good property to be able to express the
Couple of thoughts - I think tags in views is an extremely powerful tool for customer defined tags. Furthermore for some metrics like CPU metrics will never be reported from the thread that has tags. So there will never be a case when request properties got applied to global CPU perf counter. Again, perhaps we need to start filing individual issues for this feedback, as it touches some interesting points. |
@@ -23,7 +23,7 @@ | |||
import javax.annotation.concurrent.Immutable; | |||
import openconsensus.internal.StringUtils; | |||
import openconsensus.internal.Utils; | |||
import openconsensus.stats.Measure; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so you kept tests namespace for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in the SDK, I did not change that for the moment.
8f909ca
to
23c8f3e
Compare
@SergeyKanzhelev I broke my comments into two issues: #268 and #269. |
The main idea is to reduce confusion about why two top level APIs exists to record metrics/stats/measurement.
We still need to offer the ability to record raw measurements as well as pre-defined metrics (including aggregation and labels).
The structure of the Metrics package is not final:
Do we need MetricsRegistry or we move all the methods to Meter? The SDK will allow users to set Filters that apply to all created metrics (similar with metric registry in Micrometer for example).
The Views API in the SDK is not yet moved to metrics.
This PR is based on #226 which was started from a branch that lived in the main repo because that was under my account. We will move all the discussions here.